search

matthewfeickert / HEPML-env

A minimal Python3 environment for HEP machine learning with pipenv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Add explanation of project #12

Closed matthewfeickert closed 6 years ago

matthewfeickert commented 6 years ago

Resolves #10 and resolves #5

matthewfeickert commented 6 years ago

@dguest There are a few more additions that I'm going to want to make before anything gets squashed and merged, but I think this is ready for review to see if it satisfies what was brought up in Issue #10. So if you can review this and give any feedback that'd be great.

dguest commented 6 years ago

@matthewfeickert, created #17, deleted above comment

matthewfeickert commented 6 years ago

@dguest Thanks for all of your feedback on this so far --- truly helpful! Now that Issue #17 is created that has a good discussion of improvement of the install.sh I think that all the comments you made originally have been addressed now. Can you please give this another review? If there isn't anything else in the README that you think can use some attention then I'll squash and merge this and then move back to other implementation details.

@dantrim, your feedback is welcome too! :)

matthewfeickert commented 6 years ago

@dguest I'm going to merge this in now. There are still some developments that can be improved, but I think that this PR probably has reached its scope and those changes would be better suited in another one.