matthewfeickert
commented
1 week ago Also maybe worth noting that if I change the CMakeLists.txt for nanobind from using NB_STATIC
nanobind_add_module(
# Name of the extension
nanobind_example_ext
# Target the stable ABI for Python 3.12+, which reduces
# the number of binary wheels that must be built. This
# does nothing on older Python versions
STABLE_ABI
# Build libnanobind statically and merge it into the
# extension (which itself remains a shared library)
#
# If your project builds multiple extensions, you can
# replace this flag by NB_SHARED to conserve space by
# reusing a shared libnanobind across libraries
NB_STATIC
# Source code goes here
"${CMAKE_CURRENT_SOURCE_DIR}/src/nanobind_example_ext.cpp"
)to NB_SHARED
nanobind_add_module(
# Name of the extension
nanobind_example_ext
# Target the stable ABI for Python 3.12+, which reduces
# the number of binary wheels that must be built. This
# does nothing on older Python versions
STABLE_ABI
# Build libnanobind statically and merge it into the
# extension (which itself remains a shared library)
#
# If your project builds multiple extensions, you can
# replace this flag by NB_SHARED to conserve space by
# reusing a shared libnanobind across libraries
NB_SHARED
# Source code goes here
"${CMAKE_CURRENT_SOURCE_DIR}/src/nanobind_example_ext.cpp"
)that I hit undefined references earlier on in the build
...
[ 88%] Linking CXX shared library ../x86_64-el9-gcc13-opt/lib/libnanobind.so
/opt/lcg/binutils/2.40-acaab/x86_64-el9/bin/ld: CMakeFiles/nanobind.dir/usr/AnalysisBaseExternals/25.2.30/InstallArea/x86_64-el9-gcc13-opt/lib/python3.11/site-packages/nanobind/src/nb_internals.cpp.o: in function `nanobind::detail::init(char const*)':
/usr/AnalysisBaseExternals/25.2.30/InstallArea/x86_64-el9-gcc13-opt/lib/python3.11/site-packages/nanobind/src/nb_internals.cpp:351: undefined reference to `PyInterpreterState_Get'
/opt/lcg/binutils/2.40-acaab/x86_64-el9/bin/ld: /usr/AnalysisBaseExternals/25.2.30/InstallArea/x86_64-el9-gcc13-opt/lib/python3.11/site-packages/nanobind/src/nb_internals.cpp:351: undefined reference to `PyInterpreterState_GetDict'
/opt/lcg/binutils/2.40-acaab/x86_64-el9/bin/ld: /usr/AnalysisBaseExternals/25.2.30/InstallArea/x86_64-el9-gcc13-opt/lib/python3.11/site-packages/nanobind/src/nb_internals.cpp:355: undefined reference to `PyUnicode_FromFormat'
/opt/lcg/binutils/2.40-acaab/x86_64-el9/bin/ld: /usr/AnalysisBaseExternals/25.2.30/InstallArea/x86_64-el9-gcc13-opt/lib/python3.11/site-packages/nanobind/src/nb_internals.cpp:359: undefined reference to `PyDict_GetItem'
/opt/lcg/binutils/2.40-acaab/x86_64-el9/bin/ld: /usr/AnalysisBaseExternals/25.2.30/InstallArea/x86_64-el9-gcc13-opt/lib/python3.11/site-packages/nanobind/src/nb_internals.cpp:362: undefined reference to `PyCapsule_GetPointer'
...
After discussing with @nilserik78 today, I revised this repository to show multiple examples and then an issue.
As of https://github.com/matthewfeickert/atlas-cmake-nanobind-example/commit/9c812d48b94f427cdf010694406cba44c29137ac:
normal_cmakedirectory there is thenanobindsimple example from the docs that builds and works fine with normal CMake and can be built withbuild_normal_cmake.sh.atlas_cmakedirectory there is a simple C++ library and program example (based off of @henryiii'ssimple-examplefrom his CMake book) that is structured to work with ATLAS CMake's structure. Namely:CMakeLists.txtfor the entire project (located atatlas_cmake/Projects/WorkDir).package_filters.txtthat is passed to ATLAS CMake as theATLAS_PACKAGE_FILTER_FILECMake argument.CMakeLists.txtfor subprojects usingatlas_subdirinstead ofproject.However, on the
feat/get-nanobind-example-workingbranch, if I try to take thenanobinddocs example and naively port it over to build with ATLAS CMake then I get linking errors.The attached log is from running
(build_atlas_cmake_error.txt) and as can be seen from this snippet,
nanobindexists and is found, but the linking goes very wrong with lots of undefined references to CPython's C-API exceptionsI haven't fully dug in here, but general advice and debugging suggestions would be welcome.
cc @kratsg @ekourlit @henryiii @lukasheinrich @nikoladze @jpivarski @Moelf @alexander-held