search

matthewfranglen / postgres-elasticsearch-fdw

Postgres to Elastic Search Foreign Data Wrapper
MIT License
108 stars 32 forks source link

Added option use_ssl. #10

Closed aksel closed 4 years ago

aksel commented 4 years ago

Hi, first of all, thanks for the wrapper! It has helped simplify our setup greatly :smile:

Our Elasticsearch connection requires SSL to be enabled. I created a fork that exposes the use_ssl flag to the options.

Note: I have barely any experience in Python, so maybe don't accept this pull request:sweat_smile:

Ideally, you should be able to set all options that can be passed to Elasticsearch. Maybe a JSON that is simply passed down to Elasticsearch? I dunno.

This works for us though.

matthewfranglen commented 4 years ago

Thanks for the PR. I'll have a think about your proposal regarding the configurability of the client.

matthewfranglen commented 4 years ago

So I've thought about it and I think your idea of having a way to completely configure the elasticsearch client is reasonable. I've written something that will pass any additional options to the elasticsearch client.

So instead of accepting this PR I was hoping you could evaluate this branch: https://github.com/matthewfranglen/postgres-elasticsearch-fdw/tree/all-options-to-es which should be a drop in replacement. Could you to test that branch and let me know if it works?

aksel commented 4 years ago

That does indeed work for us! :clap:

matthewfranglen commented 4 years ago

FYI I released this as 0.8.0