search

matthewgani / pe

0 stars 0 forks source link

Editing freqlist.txt and adding more columns of numbers will crash the app upon restart. #2

Open matthewgani opened 3 years ago

matthewgani commented 3 years ago

To replicate: I added the 1 and 11s. The app will not detect the corrupted file and cannot remake it/ allow the user to start the app again. image.png

nus-pe-bot commented 3 years ago

Team's Response

In our user guide, it is mentioned that users are not recommended to edit the txt files directly as a warning.

image.png

Most users would not inject senseless data into the text files unnecessarily and hence, would not face this issue.

Common text file corruption involves corrupted character encoding which will retain the number of entries.This would be accounted for in our program.

image.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: Thank you for your response. I disagree with the decrease in severity to low. According to this post https://github.com/nus-cs2113-AY2021S1/forum/issues/117, it is still a valid bug despite you recommending the user not to edit the txt files. According to this post https://github.com/nus-cs2113-AY2021S1/forum/issues/136 which I agree with, a high severity or at least medium is warranted if the user is unable to start up the app the next time and the bug renders the app unusable. I would think adding a few extra lines in a txt file is not an uncommon occurrence when a text file is corrupted and does not seem to be a complicated type of corruption so it could have been dealt with without too much problems.Therefore, I believe it should be a high severity or at least medium.