ENH: Allow arbitrary date formats

matthewgilbert / pdblp

pandas wrapper for Bloomberg Open API

MIT License

241 stars 67 forks source link

ENH: Allow arbitrary date formats #72

Open ludaavics opened 4 years ago

ludaavics commented 4 years ago

When generating dates dynamically I've found it tedious to convert the objects to the required format.

[X] Added test cases with various date formats. All the tests pass with two exceptions, test_bulkref_two_ticker_one_field and test_bsrch. However, these tests currently fail in the main branch as well
[X] passes git diff upstream/master -u -- "*.py" | flake8 --diff
[X] whatsnew entry

matthewgilbert commented 4 years ago

Thanks @ludaavics, will review when I get some free time.

ludaavics commented 4 years ago

hi @matthewgilbert -- just checking if you have any issue with the pr?

Thanks!

matthewgilbert commented 4 years ago

@ludaavics thanks for the PR. I reviewed it but I think a big change to the public facing API (even though this should be backwards compatible) is not something I want to introduce into the library at this point. I think this type of behaviour could be supported via decorators, so that is one option for supporting the behaviour in your own applications.