Open shjin404 opened 4 years ago
I agree this would be a nice feature to have but will likely not have the time to implement this in the foreseable future. Currently the parsing of the responses happens throughout the library instead of in a centralized place, so implementing this check would be a bit involved. To test would also involve adding mocking since these responses can only be replicated when your limits are hit.
Thanks. At least I have some fixes that I have currently sprinkled the error checking and it worked fine for my use. I will send a pull request on your way soon.
Just sent a new pull request. I am trying to figure out how to link the pull request with this issue. I am completely new to Github workflow.
Code Sample
Problem description
When daily limit has reached, I get TypeError: string indices must be integers
When enabling debug, this is trace:
Expected Output
It would be great if _parse_ref() function can understand the PARTIAL_RESPONSE event type and report actual error rather than TypeError which is hiding underlying error.
Version Information
[paste the output of
pdblp.__version__
here below this line] '0.1.8'Thank you
Thank you for awesome library.