matthewhchan / linkify

MIT License
38 stars 8 forks source link

Fix #8: Allow internal links #13

Closed davisriedel closed 8 months ago

davisriedel commented 8 months ago

@matthewhchan thank you for your awesome plugin!

This PR allows using internal links (e.g. [[test]]) in the plugin. As I needed the feature myself and saw that there also was an open issue asking for it, I decided to implement it.

While this was possible using the Obsidian URI-scheme obsidian://open?file=$1, I believe this is not very user friendly, as it is not obvious and you have to URI encode the destination file path. Now you can just enter an internal link as target.

Once a match is detected, we check if the target is an internal link, and if so we open the file directly in Obsidian. Otherwise we open the external link.

Note: I also had to update some dependencies, because I was getting an error with codemirror types. I suggest commiting the lockfile to the repo.

matthewhchan commented 8 months ago

Thanks for the PR.