search

matthewhirschey / ddh.org

datadrivenhypothesis.org is a resource to query 100+ GB of raw biological science data to develop data-driven hypotheses
2 stars 7 forks source link

Lineage Plots #95

Closed matthewhuang457 closed 4 years ago

matthewhuang457 commented 4 years ago

Lineage and Sublineage boxplots for ddh

matthewhirschey commented 4 years ago

@matthewhuang457 Two requested changes:

  1. The convention in this project is to generate all data in the generate data scripts, and then to load it in the app. You generate a data frame in the app. So please change. This code would probably go in generate_depmap_data.R. After moving the code there, then you can simply load the Rds file, as we've done for the others.

  2. Can you give the functions simpler and more intuitive names? Perhaps make_lineage() and make_sublineage(). I try to use "snake_case" instead of "camelCase", but this is a matter of style. And I"m trying to keep style the same.

matthewhuang457 commented 4 years ago

@matthewhirschey Done!