search

matthewhively / TheorycraftClassic

Tells you everything about an ability, right on the tooltip.
MIT License
1 stars 1 forks source link

Tainted code path #1

Open matthewhively opened 2 years ago

matthewhively commented 2 years ago 
Message: [ADDON_ACTION_FORBIDDEN] AddOn 'TheorycraftClassic' tried to call the protected function 'GuildControlSetRank()'.
Time: Fri Nov 12 23:45:51 2021
Count: 1
Stack: [ADDON_ACTION_FORBIDDEN] AddOn 'TheorycraftClassic' tried to call the protected function 'GuildControlSetRank()'.
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:2515: in function `GuildControlPopupFrame_Initialize'
[string "@Interface_TBC\FrameXML\FriendsFrame.lua"]:973: in function `FriendsFrame_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>
[string "=[C]"]: in function `SetGuildRosterShowOffline'
[string "*:OnClick"]:7: in function <[string "*:OnClick"]:1>

As usual this has nothing to do with the actual code path listed.

I have not found any reliable reproduction steps yet, so this will have to wait until those are found. The only clue I have is it usually happens when I check the "show offline members" flag in the guild pane. But it does not always happen. (or maybe once per play session... not sure)

matthewhively commented 2 years ago

Probably related to the other taint issues other mods have had. Something related to drop down menus? see Questie/Modules/WorldMapTaintWorkaround.lua

The solution that solved (or at least lessened the taint) in other mods has been to try to reduce the number of global variables that exist in the lua. So first idea is to fix variables that should be local instead of global. The ONLY globals should be SavedVariables and the frame names, and their associated methods.