matthewhudson / current-device

📱 The easiest way to write conditional CSS and/or JavaScript based on device operating system (iOS, Android, Blackberry, Windows, Firefox OS, MeeGo), orientation (Portrait vs. Landscape), and type (Tablet vs. Mobile).

https://matthewhudson.github.io/current-device/

MIT License

3.95k stars 586 forks source link

Detect iPad when runs iPadOS 13 or up #222

Closed RTeran closed 4 years ago

RTeran commented 4 years ago

This PR solves this issue: https://github.com/matthewhudson/current-device/issues/217

coveralls commented 4 years ago

Coverage increased (+0.3%) to 63.504% when pulling c2162688e259069ae426aacecb5e45c120e53331 on RTeran:detect_ipad_in_ipados into 8a12df056ac4d3d8dac3333c5a54d0269e5e1027 on matthewhudson:master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #222 into master will increase coverage by 0.18%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   71.52%   71.71%   +0.18%     
==========================================
  Files           1        1              
  Lines         151      152       +1     
==========================================
+ Hits          108      109       +1     
  Misses         43       43

Impacted Files	Coverage Δ
src/index.js	`71.71% <100%> (+0.18%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a12df0...c216268. Read the comment docs.

winternet-studio commented 4 years ago

Yes, this should be merged. It seems like the only way to fix the issue. It is also the recommended solution on stackoverflow which I guess is where submitter has it from: https://stackoverflow.com/questions/58019463/how-to-detect-device-name-in-safari-on-ios-13-while-it-doesnt-show-the-correct

matthewhudson commented 4 years ago

Now available in v0.10.0!

Thank you both!

@all-contributors please add @RTeran for code @all-contributors please add @winternet-studio for review

allcontributors[bot] commented 4 years ago

@matthewhudson

I could not determine your intention.

Basic usage: @all-contributors please add @jakebolam for code, doc and infra

For other usages see the documentation

matthewhudson commented 4 years ago

@all-contributors please add @RTeran for code

matthewhudson commented 4 years ago

@all-contributors please add @winternet-studio for review

allcontributors[bot] commented 4 years ago

@matthewhudson

I've put up a pull request to add @RTeran! :tada:

allcontributors[bot] commented 4 years ago

@matthewhudson

I've put up a pull request to add @winternet-studio! :tada:

matthewhudson commented 4 years ago

@all-contributors please add @winternet-studio for review

allcontributors[bot] commented 4 years ago

@matthewhudson

I've put up a pull request to add @winternet-studio! :tada: