SarasaGothic: Fix issue in 'path with spaces'

matthewjberger / scoop-nerd-fonts

A scoop bucket for installing nerd fonts

The Unlicense

353 stars 34 forks source link

SarasaGothic: Fix issue in 'path with spaces' #169

Closed issaclin32 closed 2 years ago

issaclin32 commented 2 years ago

This will avoid 7-zip extraction error for users whose Scoop directory contains spaces.

(e.g. C:\Users\John Smith\scoop)

github-actions[bot] commented 2 years ago

Your changes do not pass checks.

SarasaGothic-CL

[ ] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate

SarasaGothic-HK

[ ] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate

SarasaGothic-J

[ ] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate

SarasaGothic-K

[ ] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate

SarasaGothic-SC

[ ] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate

SarasaGothic-TC

[ ] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate

jonz94 commented 2 years ago

I just tested it on my machine, and I can reproduce the issue if the Scoop directory contains spaces (C:\Users\I am space\scoop in my case)

space-before

And after apply changes from this PR, everything works great!

space-after

issaclin32 commented 2 years ago

I am merging this because if we leave this PR for too long, automatic version updates may cause conflicts in the PR. @matthewjberger sorry about this, hope you don't mind.

matthewjberger commented 2 years ago

@issaclin32 no problem at all! I've been traveling a lot recently for work and visiting family so I haven't had much time! Feel free to merge anything you feel is suitable, I trust you and @jonz94 :)