search

matthewjberger / scoop-nerd-fonts

A scoop bucket for installing nerd fonts
The Unlicense
353 stars 34 forks source link

CascadiaCode NF v2.2.1 install failure - filename changes #189

Closed bbomgardner closed 1 year ago

bbomgardner commented 1 year ago

The latest patched CascadiaCode filenames now include weight suffix directly before the extension so they no longer match the manifest Get-ChildItem filter: *Complete Windows Compatible.*.

I can submit a PR but I don't know if only the CascadiaCode manfest should be patched or if there is an updated generate-manifests.ps1 somewhere else where this should be done instead.

Thanks!

jonz94 commented 1 year ago

Thanks for reporting the issue!

I just push a commit that should fix the problem.

@bbomgardner can you help me to check if the issue is fixed? Thanks!

jonz94 commented 1 year ago

Closed via #190

Owstin commented 1 year ago

I just ran into this same issue with the latest version Cascadia Code NF. Did some digging and found that the fix from https://github.com/matthewjberger/scoop-nerd-fonts/pull/190 was reverted in https://github.com/matthewjberger/scoop-nerd-fonts/pull/211.

jonz94 commented 1 year ago

Ah, sorry for the inconvenience.

I just push some updates, and the issue should be fixed.

jonz94 commented 1 year ago

Closed via #214