search

matthewjberger / scoop-nerd-fonts

A scoop bucket for installing nerd fonts
The Unlicense
364 stars 34 forks source link

Add Cascadia Code #19

Closed johannesegger closed 4 years ago

johannesegger commented 4 years ago

fixes #18

linyinfeng commented 4 years ago

Hash is missing in the manifest.

johannesegger commented 4 years ago

Because the hash should come from the server, shouldn't it? It doesn't feel right to take the hash from the file I just downloaded as the right hash, because that defeats the whole purpose of a hash, doesn't it?

matthewjberger commented 4 years ago

For scoop manifests, a hash is included so that there is a reference hash. When scoop downloads a file it will check the hash of the downloaded file against the one in the manifest. If they match you got the intended file. The rest of the manifest looks good to me, so once the hash is added I'll merge the PR. And thank you for your contribution!

johannesegger commented 4 years ago

Ok, thanks for clarification. I added the suggested hash.