somewhat confusing `uninstaller` script logging output

[ZaLiTHkA]

so.. really silly one, but I just lost about 20 minutes trying to work out why scoop update meslo-nf told me:

The 'meslo-nf' Font family has been uninstalled and will not be present after restarting your computer.

considering I was updating this package, I most definitely not expected to see a message like that.

---

checking the manifest for this font package here, I worked out this is printed to the console host from this line.

and while this makes perfect sense for uninstalling the package, it is confusing for updating the package, as per the following snippet:

Updating 'meslo-nf' (2.1.0 -> 2.2.1)
Downloading new version
Meslo.zip (69,5 MB) [=======================================================================================================================================] 100%
Checking hash of Meslo.zip ... ok.
Uninstalling 'meslo-nf' (2.1.0)
Running uninstaller script...
The 'meslo-nf' Font family has been uninstalled and will not be present after restarting your computer.
Unlinking ~\scoop\apps\meslo-nf\current
Installing 'meslo-nf' (2.2.1) [64bit] from nerd-fonts bucket
Loading Meslo.zip from cache
Extracting Meslo.zip ... done.
Running installer script...
Linking ~\scoop\apps\meslo-nf\current => ~\scoop\apps\meslo-nf\2.2.1
'meslo-nf' (2.2.1) was installed successfully!

purely in the interest of avoiding future confusion, would it be possible to disable this line and re-generate this bucket's manifest files?

[jonz94]

Hi, thanks for the suggestion.

while this makes perfect sense for uninstalling the package, it is confusing for updating the package

This is actually doable. By checking the $cmd variable, we can know that the user is currently uninstall or update the font, and then disable the message when the current action is update.

[ZaLiTHkA]

This is actually doable. By checking the $cmd variable, we can know that the user is currently uninstall or update the font, and then disable the message when the current action is update.

as nifty as that is, in my opinion it's a little unnecessary.. if a user is uninstalling something, then the natural result is that it "will not be present after restarting your computer". so basically, this message doesn't do anything to enhance the feedback from an "explicit uninstall" user action, and it only serves to confuse matters from an "explicit update" user action...

if there are no errors from running a command, then the action carried out by the explicit user command "just worked". so in my honest opinion: unless you can think of a good reason to keep this, I would say it's better to simply remove that line and call it a day. :)

[matthewjberger]

The message is meant to imply that the font is flagged for uninstallation but will stay on the system until the next restart. Fonts are unique in that way

[ZaLiTHkA]

The message is meant to imply that the font is flagged for uninstallation but will stay on the system until the next restart. Fonts are unique in that way

thanks for the clarification.. personally, I still feel it's unnecessary. but that's the joy of opinions; they're free for everybody. (:

entirely up to you guys though. 🖖🏼