search

matthewkastor / object-merge

Merges JavaScript objects recursively without altering the objects merged.
16 stars 9 forks source link

Move license to root, remove License dir #11

Closed codfish closed 7 years ago

codfish commented 8 years ago

Solves https://github.com/matthewkastor/object-merge/issues/10

see: https://github.com/yarnpkg/yarn/issues/680

I've confirmed this is what Yarn is choking up on.

Since the two dependencies of this package are clone-function and object-foreach, which have the same license directory structure, I had to fix those as well, and tested by pointing to my branches here:

"dependencies": {
  "clone-function": "codfish/clone-function#move-license",
  "object-foreach": "codfish/object-foreach#move-license"
}

image

Worked well once all 3 repos were updated. Obviously this is something that needs to be fixed in Yarn, but I don't see the harm in updating these packages to just put the license in the root directory if that fixes the issue. Thoughts?

duderdice commented 8 years ago

+1 on this PR. I'm getting the error in "yarn" due to this issue.