matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad
GNU General Public License v3.0
346 stars 62 forks source link

Convert script to python package. #11

Closed sophiekovalevsky closed 4 years ago

sophiekovalevsky commented 4 years ago

I have added a couple of enhancements in how we call kicad jlc tool.

Here is the summary:

You can test it issuing:

pip install git+https://github.com/sophiekovalevsky/JLCKicadTools.git@518ec7dac5b1df354ee77905b6233245711f822c

Once the merge is done, in the README there is a content that stays how user should download package from upstream repo.

I am looking forward to your feedback.

sophiekovalevsky commented 4 years ago

@matthewlai

I have made changes you suggested. Let me know if I miss something else.

If there is an additional change I will probably will work on that in about two weeks since I will away from development.

Best,

matthewlai commented 4 years ago

Looks good to me. Thanks for working on this!

matthewlai commented 4 years ago

Hi @sophiekovalevsky , do you have a moment to take a look at this please?

https://github.com/matthewlai/JLCKicadTools/issues/15

Thanks!

sophiekovalevsky commented 4 years ago

@matthewlai I will