check ref before grouping

matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad

GNU General Public License v3.0

346 stars 62 forks source link

check ref before grouping #20

Closed Shackmeister closed 4 years ago

Shackmeister commented 4 years ago

Not sure why the original code didn't work, so this might be more of a workaround than an actual fix. If I have some time, I'll make a bugreport on GItlab for the upstream version

matthewlai commented 4 years ago

The original code doesn't work because the comp class's eq operator implementation only checks value and footprint. Can you make the change there instead?

https://github.com/matthewlai/JLCKicadTools/blob/6e19b39dea3fa3014f29e1715333116c6c34c6ad/jlc_kicad_tools/jlc_lib/kicad_netlist_reader.py#L338

Shackmeister commented 4 years ago

oh thats right. Thanks! Should be fixed there now

matthewlai commented 4 years ago

Thanks!

Shackmeister commented 4 years ago

NP, and thanks for the assistance. I should probably get back to ordering my board :D

matthewlai commented 4 years ago

Good luck with that!

Shackmeister commented 4 years ago

Fixed in Kicad master https://gitlab.com/kicad/code/kicad/-/commit/9ca61b50b6beb385b5b80c4bd5eae055b1609e7d