matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad
GNU General Public License v3.0
346 stars 62 forks source link

Fix orientation for SOD-123 Diodes #21

Closed Shackmeister closed 4 years ago

matthewlai commented 4 years ago

Are you sure about this one? I have a board assembled using that footprint and it works...

Shackmeister commented 4 years ago

This is what I get with that setting, just tested on 2 boards Screenshot from 2020-05-06 00-03-43

TobleMiner commented 4 years ago

I suggest merging #22 in favor of this PR since JLC seems to have changed orientation for all 2 terminal diode packages.

matthewlai commented 4 years ago

Merging #22 instead since it covers other diode packages, too. Thanks all!