search

matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad
GNU General Public License v3.0
346 stars 62 forks source link

Remove diode rotation fixes #22

Closed TobleMiner closed 4 years ago

TobleMiner commented 4 years ago

JLC changed the handling of diodes regarding their orientation. They either changed the default rotation by 180° or reversed the meaning of + and -.

This is how a PCB looks with my changes applied: LJC_diode_rotation

I've confirmed with JLC that + designates the anode while - is the cathode. This is the E-Mail they sent me in response: JLC_email

TobleMiner commented 4 years ago

Some additional evidence: JLC_HB_Sensor_Diode

Note the orientation of diode D1. The left PCB shows the original orientation produced by JLCKicadTools. The right PCB is the manual placement correction by JLC. D1 has been rotated by 180°. Thus we should not apply any rotation.

Manawyrm commented 4 years ago

The orientation of diodes is documented here: https://support.jlcpcb.com/article/99-does-the-red-dot-means-pin-1-in-the-placement-previewer

matthewlai commented 4 years ago

Looks good to me, thanks!