matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad
GNU General Public License v3.0
346 stars 62 forks source link

add Resistor network rotation #25

Closed Shackmeister closed 4 years ago

purdeaandrei commented 4 years ago

Hey!

Why did you close this PR? I also had: +"^R_ArrayConvex",90 +"^R_ArrayConcave",90 In my PR I was working on, which is pretty much the same as your PR, since these SMD footprints are simmetric.

I'm removing this from my bottom-fixes PR now, just to make the PR have a singular purpose, but I'd like to understand why you closed your PR. Did you find an example of resistor networks not needing correction?

Andrei

purdeaandrei commented 4 years ago

@Shackmeister alright so I carved out my resistor-array related change into a separate PR: https://github.com/matthewlai/JLCKicadTools/pull/34

It is effectively almost equivalent to what this PR would have done. (Except the filter is less wide, and the rotation is in the other direction, but I belive both are correct)

Do you have any reservations against my PR?

Andrei