Moving requirement for logzero to setup.py

matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad

GNU General Public License v3.0

340 stars 60 forks source link

Moving requirement for logzero to setup.py #72

Closed kroesche closed 2 years ago

kroesche commented 2 years ago

Thank you for making this tool. It is very useful for generating JLC production files.

Is there a reason you have the two-step install, using pip to install requirements instead of just putting the requirement for logzero in the setup.py file? If not, then I would be happy to submit a PR to move this requirement into the setup.py.

matthewlai commented 2 years ago

@sophiekovalevsky

sophiekovalevsky commented 2 years ago

@matthewlai, thanks to ping, otherwise I couldn't catched.

@kroesche, there is no particular reason and I think what you brought up is actually a great idea. I would be happy to review your PR.

kroesche commented 2 years ago

I submitted PR https://github.com/matthewlai/JLCKicadTools/pull/73