search

matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad
GNU General Public License v3.0
340 stars 60 forks source link

Move dependency requirements to setup.py from requirements.txt #73

Closed kroesche closed 2 years ago

kroesche commented 2 years ago

PR made in response to https://github.com/matthewlai/JLCKicadTools/issues/72

I added the requirements for external dependency to setup.py and deleted requirements.txt. I set the version to >= 1.5, as you had it pinned to 1.5.0 in the requirements file. If there is some reason it must be 1.5.0 and cannot be more recent (such as the current 1.7) then this will need to be changed.

sophiekovalevsky commented 2 years ago

@kroesche thanks. I tested here and works well. One tiny detail would be to fix ci errors. Once that is done I'll merge.

kroesche commented 2 years ago

Okay I will try to address CI error.

kroesche commented 2 years ago

I ran the CI in my fork this time and I believe it is now passing.

sophiekovalevsky commented 2 years ago

@kroesche thanks.