Fixed rotation of components on the bottom of the board

matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad

GNU General Public License v3.0

346 stars 62 forks source link

Fixed rotation of components on the bottom of the board #78

Closed matthew-suter closed 2 years ago

matthew-suter commented 2 years ago

If a component has a rotation offset of 0° or 180°, it will be 180° off if it is on the bottom of the board. This fix does not affect components with 90° or 270° offsets, which I assume is what this script was tested with.

matthewlai commented 2 years ago

Thanks!

purdeaandrei commented 2 years ago

Hey. Just to let you know, the previous code (before this PR) was correct for all components. However JLCPCB has recently changed how they interpret bottom layer rotation, as a result all components that used the previous code were 180-degrees rotated (not just the 0 and 180 offset components). So this fix only addresses the issue partially. I will submit a PR to solve this in a couple seconds.