search

matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad
GNU General Public License v3.0
340 stars 60 forks source link

Correctly fix bottom layer rotations for all component adjustments. #79

Closed purdeaandrei closed 2 years ago

purdeaandrei commented 2 years ago

It looks like JLCPCB has changed how they interpret bottom layer rotations. A project I had ordered before (with unmodified bom and cpl files) had all its components rotated by 180 degrees.

Looks like Pull request https://github.com/matthewlai/JLCKicadTools/pull/78 has tried to address it but it was incomplete, the current master is not rotating all components correctly yet. This PR corrects bottom layer rotation for all component types.

Some examples: 1) This is correct on both current master, and on this PR too: (this is a 180-degree corrected component) image 2) The following is incorrect on master: (this is a 270-degree corrected component) image But it's correct with this PR: image

purdeaandrei commented 2 years ago

Note: in case JLCPCB decides to revert to the previous behavior in the future, then this PR and also #78 should be reverted.

matthewlai commented 2 years ago

Thanks!