search

matthewlai / JLCKicadTools

Tool for using JLCPCB assembly service with KiCad
GNU General Public License v3.0
340 stars 60 forks source link

Uppercase designators #81

Closed jabdoa2 closed 2 years ago

jabdoa2 commented 2 years ago

It seems like JLCPCB does not process any parts with lowercase designators. This unconditionally uppercases them.

matthewlai commented 2 years ago

Looks like your repo is not at HEAD (see the second commit diff). Please pull and apply the changes to HEAD. Thanks

jabdoa2 commented 2 years ago

Looks like your repo is not at HEAD (see the second commit diff). Please pull and apply the changes to HEAD. Thanks

I branched from master when I created this. The diff looks good to me. What makes you think this is not from HEAD? I assume you mean the master branch by "HEAD".

jabdoa2 commented 2 years ago

Oh nevermind. I see it. Let me revert that part

matthewlai commented 2 years ago

Thanks!