search

matthewlloyd / Voron-Parametric

Parametric open source reconstructions of Voron printed parts
GNU General Public License v3.0
28 stars 10 forks source link

Add z_joint_upper_hall_effect #7

Closed emutt11 closed 3 years ago

emutt11 commented 3 years ago

This was a simple save as of the z_joint_upper_x4 but with an extra hole.

So I sent a reply to my last pull request after it was closed as I had some comments/questions on the F360 golden rule. Since it was closed, I guess that might not be the best place to continue the conversation. What is the best practice for continuing I dialogue using github?

Anyways, I am now also including those same comments in this request:

image

After submitting that I tinkered around a bit in F360 and discovered part/assembly differences where if you do not have any internal components in a model, F360 seems to identify it as a part (see the box by the filename)

image

Once a component is created/added this symbol changes to a stack of boxes

image

When adding these two types of files into a top layer assembly file, notice the z_joint_upper_hall_effect v2 without an internal component, and the v3 version with and internal component. V3 has an extra layer that seem unwanted.

Just my two cents, let me know what you think.

emutt11 commented 3 years ago

I am closing this, apparently the z_joint_upper_hall_effect.f3d was not include. I will try again.