matthewmueller / joy

A delightful Go to Javascript compiler (ON HOLD)
https://mat.tm/joy
GNU General Public License v3.0
1.32k stars 35 forks source link

Fixed bad fmt.Fprintf at 'joy serve' #91

Closed intelfike closed 6 years ago

intelfike commented 6 years ago

Fixed bug.

'joy serve' couldn't use '%' in source code.

-       fmt.Fprintf(w, src)
+       fmt.Fprint(w, src)

Example of issue

joy.go

if n%3 == 0 {
    return "Fizz"
}

http://localhost:8080/bundle.js

if (n %! (MISSING)== 0) {
    return "Fizz";
};
intelfike commented 6 years ago

It passed all test in local environment, but it couldn't pass SemaphoreCI's test.

command

go test -v ./...

How to pass SemaphoreCI's test? (I searching.) Is it okay to create PullRequest again?

matthewmueller commented 6 years ago

Awesome – thanks!

I'll take a look at the semaphore stuff :-)

intelfike commented 6 years ago

Oh, was it not important to pass the SemaphoreCI test at the Pull request?

Thanks for marge. I can't wait stable version!