matthewmueller / x-ray

The next web scraper. See through the <html> noise.
MIT License
5.87k stars 349 forks source link

Total Refactor, a New Hope #142

Closed Kikobeats closed 8 years ago

Kikobeats commented 8 years ago

Basic

Kikobeats commented 8 years ago

Please join in travis-ci.org and activate this repository to enable travis on PR. Do the same for https://coveralls.io/ as well.

Kikobeats commented 8 years ago

Phantom test still broken:

driver(fn)
  x-ray params: {"source":"http://www.google.com/ncr","scope":null,"selector":"title"} +4ms
  x-ray starting at: http://www.google.com/ncr +0ms
  x-ray fetching http://www.google.com/ncr +0ms
phantom stdout: NETWORK_ERR: XMLHttpRequest Exception 101: A network error occurred in synchronous requests.

phantom stdout:   phantomjs://code/shim.js:1815 in send
  phantomjs://code/shim.js:1815 in _start
  phantomjs://code/shim.js:1842
matthewmueller commented 8 years ago

+1 looks good :-)

i've gone ahead and given you commit and publishing access to this project. for big things, please open a PR. thanks for your help!

matthewmueller commented 8 years ago

added travis and coveralls to this project :-)

kichooo commented 8 years ago

Nice!

kichooo commented 8 years ago

Wait, so you just removed all semicolons and called it a refactor? :S

syzer commented 8 years ago

@kichooo not only ; , also function name(args) => function name (args)

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling fc9b6d52a0d1a6ddee4aea47a9d1869e12ffb760 on Kikobeats:refactor into \ on lapwinglabs:master**.