Support x-ray-parse filters

matthewmueller / x-ray

The next web scraper. See through the <html> noise.

MIT License

5.87k stars 349 forks source link

Closed fabien closed 8 years ago

fabien commented 8 years ago

I noticed that x-ray-parse supports the notion of filters. This PR enables this functionality in Xray.

Kikobeats commented 8 years ago

Hey,

It looks good. This afternoon I'm going to fix codebase test. Also consider add specific tests for this feature to be sure that all is ok!

fabien commented 8 years ago

Thanks! I've added a basic test - would be nice to have the other (commented out) tests working again, too. Looking forward to your 2.1 release!

Kikobeats commented 8 years ago

I merged my branch; consider prepare for the next build 😃

fabien commented 8 years ago

@Kikobeats great! Do you want me to fix any merge conflicts, so you can handle this PR?

Kikobeats commented 8 years ago

@fabien yes! how many conflicts do you have? maybe we can resolve it here?

fabien commented 8 years ago

/cc @Kikobeats