search

matthewmueller / x-ray

The next web scraper. See through the <html> noise.
MIT License
5.88k stars 350 forks source link

examples broken #173

Closed pvijeh closed 5 years ago

pvijeh commented 8 years ago

the examples dont work

/Users/peter/Desktop/projects/www/web-scraper/x-ray/examples/collection-of-collections/index.js:3 var html = read(path.resovlve(__dirname, 'index.html')) ^

TypeError: path.resovlve is not a function at Object. (/Users/peter/Desktop/projects/www/web-scraper/x-ray/examples/collection-of-collections/index.js:3:22) at Module._compile (module.js:398:26) at Object.Module._extensions..js (module.js:405:10) at Module.load (module.js:344:32) at Function.Module._load (module.js:301:12) at Function.Module.runMain (module.js:430:10) at startup (node.js:141:18) at node.js:980:3

vivdev commented 8 years ago

It's the same typo in all examples:

path.resovlve which should be path.resolve instead.

And there is one more fix needed, it should be 2 directories up in each example like below:

var Xray = require('../..')

I could run all the examples after these changes. I can fix this, if someone gives me the permissions to repo.

lathropd commented 5 years ago

Subsequently fixed by a PR.