Formal changes + display change

[victoramoureux]

• There are formal changes which are relatively minor.
• For the purpose of the analysis, I add two other concepts of income: inc5, which is inc3 - SSR and inc6, which is inc3-SSR-SSE. I know that inc5 is normally dhi - VAT but one can change the number of the new concepts of income (e.g. inc6 and inc7) if we want. It seems important to keep a digit (easier for the foreach loops)
• The change in the display is designed to be more exhaustive than the previous one. It does not require a special sort to have the deciles : the deciles of inci' are ranked by inci' (this is the reason of the _`i' subscript in the previous loop).

[matthewolckers]

I am concerned that we subtract hxits twice when generating inc6 because hxits is part of tax. We are also subtracting hsscer twice when generating inc5. This is because: tax = hxit + hsscer and hxit = hxiti + hxits @victoramoureux what am I missing?

[victoramoureux]

@matthewolckers I am not 100% sure I see your point but inc6 is defined as follows: gen inc6 = marketincome + allpension + transfer - hsscer - hxits so there is no tax in the definition of inc6 or inc5 right? The confusion may come from the fact I call them inc5 and inc6 but they are not calculated after inc4 (which is inc3 - taxes) : it was just easier for the foreach loops (i in 1/6 is easier to read than i in $incconcept etc.). Put differently, inc6 is just inc4 + hxiti and inc5 is inc4 + hxiti + hxits Maybe I should call them differently, what do you think?

[matthewolckers]

@victoramoureux Ok, I understand now. Yes, the naming is confusing. Please change the naming to something else like inc4_fg and inc4_fn for France Gross and France Net.

[victoramoureux]

Hi @matthewolckers , I've just renamed the variables to inc3_SSER and inc3_SSEE. Names are a bit longer now but less confusing.