search

mattheworiordan / capybara-screenshot

Automatically save screen shots when a Capybara scenario fails
MIT License
1.02k stars 168 forks source link

Screenshots that are uploaded to S3 are reported with local file path #198

Open stevehanson opened 7 years ago

stevehanson commented 7 years ago

I have my test suite configured to upload images to S3 when running on my CI server, and it's working great! The only issue is that when a test fails and Capybara-Screenshot reports the screenshot location, it lists a local path instead of the S3 path:

HTML screenshot: file:///Users/shanson/dev/myproject/tmp/capybara/screenshot_2016-12-14-16-21-46.125.html
  Image screenshot: file:///Users/shanson/dev/myproject/tmp/capybara/screenshot_2016-12-14-16-21-46.125.png

The file is actually available on S3, and I can get to it by substituting the path, but I was just wondering if there are any plans to update the reporting to give the fully qualified S3 URL when uploading to S3. Thanks!

rzaharenkov commented 7 years ago

Please find the fix here: https://github.com/mattheworiordan/capybara-screenshot/pull/221