search

mattheworiordan / capybara-screenshot

Automatically save screen shots when a Capybara scenario fails
MIT License
1.02k stars 168 forks source link

Ensure the reporter module is not loaded multiple times. #205

Closed ArturT closed 7 years ago

ArturT commented 7 years ago

Ensure the reporter module is not loaded multiple times when before(:suite) is run multiple times because of calling RSpec::Core::Runner more than once.

Related issue: https://github.com/buildkite/docs/pull/99

This PR fix problem with capybara-screenshot not working with gem knapsack_pro

toolmantim commented 7 years ago

This fixes it for me!

ArturT commented 7 years ago

I noticed the tests failed for ruby 2.0.0 on travis. But it's a separate issue: https://github.com/mattheworiordan/capybara-screenshot/issues/206

mattheworiordan commented 7 years ago

Excellent, thanks for this contribution.

ArturT commented 7 years ago

@mattheworiordan Thanks for merging. Are you going to release a new gem version soon?