search

mattheworiordan / capybara-screenshot

Automatically save screen shots when a Capybara scenario fails
MIT License
1.02k stars 168 forks source link

Fix aggregate_failure tests #220

Closed Casao closed 7 years ago

Casao commented 7 years ago

RSpec's aggregate_failures: true does not result in an exception being set on an example. After digging into RSpec's code, it uses a failure notifier to determine if the test has failed. If the example has metadata indicating it's aggregating failures, this checks the failure notifier to determine if it should screenshot.

None of the rspec specs pass locally for me (on this or on master), but I believe they should work fine.

Casao commented 7 years ago

I've just noticed #213 exists, and it fixes it better.