search

mattheworiordan / capybara-screenshot

Automatically save screen shots when a Capybara scenario fails
MIT License
1.02k stars 168 forks source link

Fix ruby version compares #231

Closed iguchi1124 closed 6 years ago

iguchi1124 commented 6 years ago

String instance of "2.2.2" is bigger than "2.2.10", so I use Gem::Version to compare semvers

related https://github.com/mattheworiordan/capybara-screenshot/pull/229

iguchi1124 commented 6 years ago

what do you think? @mattheworiordan

mattheworiordan commented 6 years ago

So much better, my implementation was crappy! Thanks @iguchi1124