Add Appraisal gemset for Capybara 2 and 3

mattheworiordan / capybara-screenshot

Automatically save screen shots when a Capybara scenario fails

MIT License

1.02k stars 168 forks source link

Add Appraisal gemset for Capybara 2 and 3 #241

Open mattheworiordan opened 5 years ago

mattheworiordan commented 5 years ago

See https://github.com/mattheworiordan/capybara-screenshot/pull/236#pullrequestreview-166802421 for backgruond.

eiapopeia commented 5 years ago

I also see the warning: capybara-screenshot could not detect a screenshot driver for 'apparition'. Saving with default with unknown results. The screenshot itself looks really well, thought.

Gems:

apparition (0.2.0)
capybara (3.20.2)
capybara-screenshot (1.0.22)

sedubois commented 5 years ago

I also got that warning when using apparition. Similar to the solution in #22, I've added this to my rails_helper.rb and it seems to work: Capybara::Screenshot.register_driver(:apparition, &:save_screenshot).

eiapopeia commented 5 years ago

Thanks for the hint. This fixes the message for me.

I think it should be already built in because apparition driver will be the default in the future.

mattheworiordan commented 5 years ago

@eiapopeia @sedubois sorry for the slow reply on this. I agree apparition is likely to win the battle here. Would either of you be willing to do a PR with my help?

mattheworiordan commented 5 years ago

See https://github.com/mattheworiordan/capybara-screenshot/pull/219/files for a related PR