mattheworiordan / capybara-screenshot

Automatically save screen shots when a Capybara scenario fails
MIT License
1.02k stars 168 forks source link

Fix path output for s3-saved screenshots #248

Closed geoffharcourt closed 5 years ago

geoffharcourt commented 5 years ago

AWS has changed their URL structure such that the prior output for screenshot location no longer works. The following change updates the format to remove the invalid dash and the region name from the bucket hostname.

mattheworiordan commented 5 years ago

Thanks @geoffharcourt. I was not aware of this change. Do you have a reference for this so that I can confident merge this? In addition, this PR still gets the s3_location yet it's not used. So that is surely wrong?

machty commented 5 years ago

AWS didn't change anything (that would have been a massive breaking change resulting in widespread production outages), but their documentation is very confusing. In short, not all buckets support the region-prefixed "virtual" host style URLs.

See this comment in another PR for details.

geoffharcourt commented 5 years ago

@machty thanks for the information! I guess in that case we'll change our bucket and close this PR out.