mattheworiordan / capybara-screenshot

Automatically save screen shots when a Capybara scenario fails
MIT License
1.01k stars 168 forks source link

rails 6 system spec compat #264

Closed szTheory closed 3 years ago

szTheory commented 5 years ago

I'm not sure what the best way is to add support for system specs, but this is working for me in a Rails 6 project. Maybe it can help someone else to incorporate in a cleaner way.

mattheworiordan commented 4 years ago

Interesting, thanks for the contribution. It would be great to know if anyone else has tried this and works in Rails 6? We're in the midst of Rails 6 upgrades now, so I will try out when we get there. Any feedback from the community would help.

mtmail commented 4 years ago

Works fine. Rails 6.0.2.2, capybara-screenshot 1.0.24, capybara 3.32.1

mattheworiordan commented 3 years ago

Thanksm, will merge finally, apologies for being so slow