search

mattheworiordan / capybara-screenshot

Automatically save screen shots when a Capybara scenario fails
MIT License
1.02k stars 168 forks source link

take screenshots of correct window (Updated) #287

Closed cgunther closed 2 years ago

cgunther commented 3 years ago

This is a continuation of #245, starting with @dreyks's work and trying to address @mattheworiordan's feedback.

Fixed #143

cgunther commented 2 years ago

Thanks for the merge!

I saw you bumped/tagged the version (6b80ac24fafa1e92052168807cc1dff2fa471af6) to v1.0.26, but looks like the gem didn't get pushed to RubyGems yet, it's still showing v1.0.25: https://rubygems.org/gems/capybara-screenshot

mattheworiordan commented 2 years ago

Oops, that's odd. I will look into this now.

mattheworiordan commented 2 years ago

Ok, fixed, apologies for that

cgunther commented 2 years ago

Thanks!

AlexWayfer commented 2 years ago

As I understood, this has been released as 1.0.26 at January 2022.

But I have an issue with 2 windows, probably it's another one, but you can help me (describe and ensure).

I'm using a separate driver for incognito mode, and Capybara.using_driver(:selenium_incognito) do works good with it (opens actually the second window), but at fail there (for example, click_button can't find) I'm getting a screenshot from the first (main) window.