matthewp / haunted

React's Hooks API implemented for web components 👻
BSD 2-Clause "Simplified" License
2.58k stars 92 forks source link

Remove compiled Typescript files added by bot from top-level folder #441

Closed micahjon closed 1 year ago

micahjon commented 1 year ago

These compiled files are the output of a build process and should live in the untracked lib folder.

Not sure why they were added by the Changeset Release Github Action bot... Commit: https://github.com/matthewp/haunted/commit/f6fcc6e282512827e154110619a0fd587500d542 PR: https://github.com/matthewp/haunted/pull/391

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 1df2e510a30932ec2900dcfe3c196e42f22e63ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for hauntedhooks ready!

Name Link
Latest commit 1df2e510a30932ec2900dcfe3c196e42f22e63ec
Latest deploy log https://app.netlify.com/sites/hauntedhooks/deploys/633608c1867c0400087e0cab
Deploy Preview https://deploy-preview-441--hauntedhooks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

micahjon commented 1 year ago

are these in gitignore?

No, but the lib folder is in .gitignore and that's where these built files should live.