search

matthewp / haunted

React's Hooks API implemented for web components 👻
BSD 2-Clause "Simplified" License
2.58k stars 92 forks source link

feat(create-context): don't use Shadow Root. #453

Open megheaiulian opened 1 year ago

megheaiulian commented 1 year ago

The Context's Consumer component does not need to have a ShadowRoot because it would be very hard to style elements inside it. (part)

fixes #384

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 4cb9621a78dd236e1d74aad198d5c895a3f669c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | haunted | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for hauntedhooks ready!

Name Link
Latest commit 4cb9621a78dd236e1d74aad198d5c895a3f669c8
Latest deploy log https://app.netlify.com/sites/hauntedhooks/deploys/6462103b37dc9a00083b49f2
Deploy Preview https://deploy-preview-453--hauntedhooks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

megheaiulian commented 1 year ago

@matthewp or @bennypowers Can you please have a look at this? It is very inconvenient for context consumer elements to have Shadow DOM.