search

matthewp / haunted

React's Hooks API implemented for web components 👻
BSD 2-Clause "Simplified" License
2.58k stars 92 forks source link

fix: infinite loop if effect schedules an update and then throws #469

Open cristinecula opened 1 year ago

cristinecula commented 1 year ago

Update lastValues before running the callback.

Fixes #468

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 761096fd32b1b2c5fc64a56262e2840531968a24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | haunted | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for hauntedhooks ready!

Name Link
Latest commit 761096fd32b1b2c5fc64a56262e2840531968a24
Latest deploy log https://app.netlify.com/sites/hauntedhooks/deploys/641ae94ea98698000818518d
Deploy Preview https://deploy-preview-469--hauntedhooks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

basilgood commented 1 year ago

I just tested this PR and it works very well. It's clean and nice implemented. Why it's not merged.