search

matthewp / robot

🤖 A functional, immutable Finite State Machine library
https://thisrobot.life
BSD 2-Clause "Simplified" License
1.92k stars 88 forks source link

fix: do not fire promise events after state changes #171

Closed kybarg closed 3 months ago

kybarg commented 2 years ago

fixes #141

kybarg commented 2 years ago

@matthewp any thoughts on this?

matthewp commented 2 years ago

Is this how Xstate works?

kybarg commented 2 years ago

@matthewp Yes, here is an example https://codesandbox.io/s/suspicious-pare-137g4z

matthewp commented 2 years ago

Sorry for the delay @kybarg, can you address @ehuelsmann's review and update the branch?

kybarg commented 1 year ago

@matthewp done

Hurtak commented 1 year ago

Could we merge and release this? It seems that the approach was approved, it was just never merged.

ehuelsmann commented 1 year ago

@kybarg , this PR now has conflicts. Although it's unclear from @matthewp as far as merging is concerned, could you address the conflicts so merging is an option again?

ehuelsmann commented 11 months ago

@matthewp, I don't mind updating this PR so you can include it in a next release. I'll need to create a new PR though, because I can't append to this one. Are you fine with that? Does it make sense for me to work on this?

matthewp commented 11 months ago

@ehuelsmann yep, works for me

changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: 0b2caf1336c4ad49ff15abf6161e2964ba012f28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR