Miscellaneous smaller tasks

matthewpalmer / Charter

A Swift mailing list client for iPhone and iPad

524 stars 77 forks source link

Closed matthewpalmer closed 8 years ago

matthewpalmer commented 8 years ago

[x] think about whether the data sources to the various view controllers should be turned into protocols and injected (at this stage, I'm thinking yes, but it's maybe a little tricky because of the view lifecycle)
[x] unit tests for thread detail data source
[x] add tests for formatContent on the EmailFormatter class
[x] remove various retain cycles that I've introduced
[x] go through TODOs littered throughout the codebase and open issues or fix

matthewpalmer commented 8 years ago

Implemented no.1

matthewpalmer commented 8 years ago

implemented 2 & 3

matthewpalmer commented 8 years ago

Re 4: tried to fix, may not have fixed, time will tell. The cache of view controllers in the app coordinator is probably not a good thing…

5: there weren't too many, most are already covered