matthewpalmer / Charter

A Swift mailing list client for iPhone and iPad
524 stars 77 forks source link

Load threads on viewDidLoad and minor style fixes #42

Closed denissezavala closed 8 years ago

denissezavala commented 8 years ago

Let me know what you think.

Cheers!

matthewpalmer commented 8 years ago

This is great—thanks!

My only concern is that refreshing automatically will break the UI tests (which we use for App Store screenshots). Could you please add a check around the lists refresh, something like this should work

// Check whether we are running UI tests before performing an automatic refresh.
// If we refresh immediately the screenshots (which we take with Fastlane in doing the UI tests)
// will be in an undefined state.
if !NSUserDefaults.standardUserDefaults().boolForKey("FASTLANE_SNAPSHOT") {
  // Do the refresh
}

Thanks again đź‘Ť

denissezavala commented 8 years ago

No problem—this is done in the last commit.

Cheers!