Fix new Xcode 9 warnings, update to Swift 4

matthewpalmer / Locksmith

A powerful, protocol-oriented library for working with the keychain in Swift.

MIT License

2.92k stars 268 forks source link

Fix new Xcode 9 warnings, update to Swift 4 #179

Closed emaloney closed 7 years ago

emaloney commented 7 years ago

• Fixed a redundant conformance constraint warning • Updated settings as per suggestions from Xcode 9 • set APPLICATION_EXTENSION_API_ONLY to NO for unit tests (this setting is only needed for Locksmith itself) • Updated to Swift 4 (which only required changes to the unit tests; the core Locksmith is Swift 4 compliant out-of-the-box)

clayellis commented 7 years ago

@matthewpalmer Please approve this PR quickly 🤞🏻

darthpelo commented 7 years ago

@emaloney @clayellis I checked the Travis jobs... Travis is still using Xcode 8, so jobs are falling... I was ready to create a simple PR with the support of Xcode 9 and Swift 3.2... but I think that for now I will keep mine version for a work project, waiting for good news :)

emaloney commented 7 years ago

I can take a stab at fixing the Travis issues if that's a requirement for consideration of this pull request. Unfortunately, Travis has been seriously messed up over the last few days (at least as far as their macOS infrastructure is concerned). In fact, I just checked now and the Travis CI status page is down.

phillfarrugia commented 7 years ago

@emaloney can you try updating the travis.yml to osx_image: xcode9?

matthewpalmer commented 7 years ago

Thanks @emaloney and everyone! Sorry for the delay on my end 👍. Let me know if there are any other issues, I should have time in the next week to look into it.

(P.S. @emaloney I've added you as a collaborator to Locksmith 💥)