search

matthewpalmer / Locksmith

A powerful, protocol-oriented library for working with the keychain in Swift.
MIT License
2.92k stars 268 forks source link

Swift 5.0 compatibility #205

Open taraspasichnyk opened 5 years ago

taraspasichnyk commented 5 years ago

Are you planning to update codebase?

MayankAgarwal04 commented 5 years ago

Hi Team,

I am having a trouble loading the keychain data. App crash when loadDataForUserAccount is called. Mac OS 10.14.4 and Xcode 10.2

When you guys are planning to update codebase. @matthewpalmer @victor @jonallured @hermanolsson @jakemarsh @diejmon @marcelofabri @edwellbrook @larslockefeer

mromanuk commented 5 years ago

updated Xcode and it converted my codebase to Swift 5.0 compulsively 😫. Now I need Locksmith in 5.0 😤

mromanuk commented 5 years ago

Just submitted a Pull Request to address this, hope some of the admins see it

pableiros commented 5 years ago

Is this repository deprecated?

lohithkorp commented 5 years ago

same issue for me too. any solution please?

lohithkorp commented 5 years ago

my issue is same as @MayankAgarwal04 Trouble loading the keychain data. App crash when loadDataForUserAccount is called. Mac OS 10.14.4 and Xcode 10.2 - Swift 5

mromanuk commented 5 years ago

sorry, I messed up, my comment was for a different project.

  1. Use it with PR
  2. use my fork
  3. download it yourself and put Swift 5.0 instead of 4.x

EDIT: I'm using my own fork, which just address the flag that it should compile with Swift 5.0 (it works)

abdullah-s commented 5 years ago

swift 5 upgraded, all tests passed check this out https://github.com/stephanheilner/Locksmith