1.0.1 No longer works with Objective C

[LaChrome]

Swift Struct isn't reachable in Objective C. Regift v1.0.1 removed the "public class Regift", so it no longer works with Objective C.

I'm new to swift, but is it possible to add a public class to the Regift.swift file that then calls the respective Regift struct so that we can make this useable in Objective C again?

Chris

[LaChrome]

I have started to create a helper function.

[LaChrome]

Something like this should work:

import Foundation import Regift

public class RegiftHelper: NSObject { private override init() {}

public class func createGIFFromURL(URL: NSURL, withFrameCount frameCounter: Int, delayTimer: Float, loopCounter: Int = 0) -> NSURL?
{

    let videoURL   = URL
    let frameCount = frameCounter
    let delayTime  = delayTimer
    let loopCount  = loopCounter    // 0 means loop forever

    let regift = Regift(sourceFileURL: videoURL, frameCount: frameCount, delayTime: delayTime, loopCount: loopCount)

    print("Gif saved to \(regift.createGif())")

    return regift.createGif()
}

}

[LaChrome]

For anyone looking to get Regift 1.0.1 working with an Objective C project, this is working for me:

1. Make sure you do this first: http://stackoverflow.com/questions/24206732/cant-use-swift-classes-inside-objective-c

2. Create a new swift file in your Objective C project with the following contents: ////////////////////// Regift Objective C Helper Class ///////////////////// import Foundation public class RegiftHelper: NSObject { private override init() {}

   public class func createGIFFromURL(URL: NSURL, withFrameCount frameCounter: Int, delayTimer: Float, loopCounter: Int = 0) -> NSURL? {

   let videoURL   = URL
   let frameCount = frameCounter
   let delayTime  = delayTimer
   let loopCount  = loopCounter    // 0 means loop forever
   
   let regift = Regift(sourceFileURL: videoURL, frameCount: frameCount, delayTime: delayTime, loopCount: loopCount)
   
   print("Gif saved to \(regift.createGif())")
   
   return regift.createGif()

   }

} ////////////////////// End of Regift Objective C Helper Class /////////////////////

1. Make sure you import the swift bridging header where you need to call the helper function:

   import "ProductModuleName-Swift.h"

2. Call your new helper function for Regift:

animGif = [RegiftHelper createGIFFromURL:videoURL withFrameCount:8 delayTimer:0 loopCounter:0];

[matthewpalmer]

I think I’m probably going to make Regift back into an @objc class again, since there isn't much value in it being a struct since we don't get value semantics. Hopefully I will get a chance to look at this in the next couple of days :)

Thanks for your feedback!

[matthewpalmer]

Don't think I will get a chance to look at this @Apptation, but I'm happy to accept a PR for it if you'd like it to be in master :). The main changes are to make Regift an @objc public class that subclasses NSObject, and to move the Constants struct to be private fields (and update the usages of these constants).

Feel free to reopen at any stage if you think more discussion is needed :)

[LaChrome]

I wasn't expecting you to add this in if you're switching the code back to a public class I've got regift up and running in Xcode7 with my objective c project, so I'm all good 😀 Im happy to submit the change through a pull request, but if you're going to change over to a public class anyway, it would defeat the purpose. Thanks for your help. Ps. Regift is an awesome addition to my apps! Really appreciate your work on it and making it public. Chris On Sat, Sep 19, 2015 at 2:21 AM, matthewpalmer/Regift reply@reply.github.com wrote: Don't think I will get a chance to look at this @Apptation [https://github.com/Apptation] , but I'm happy to accept a PR for it if you'd like it to be in master :). The main changes are to make Regift an @objc public class that subclasses NSObject, and to move the Constants struct to be private fields (and update the usages of these constants).

Feel free to reopen at any stage if you think more discussion is needed :)

— Reply to this email directly or view it on GitHub [https://github.com/matthewpalmer/Regift/issues/18#issuecomment-141630271] .[https://github.com/notifications/beacon/AGsyPnWqegZOhfgJ55SdzgyLTdr7mxnOks5ozPZxgaJpZM4F_oYF.gif]

[matthewpalmer]

Ah sorry I meant that if you wanted obj c support in master, the best way to do that would be to submit a PR making Regift a public class, rather than adding the RegiftHelper class

[LaChrome]

Ahh yes. I can have a crack at it. That helper file was the first thing I've ever coded in Swift.

Ps, I've been trying to use Pods to install Regift, and all I ever get is this error:

[!] Unable to satisfy the following requirements:

• Regift required by Podfile

Every other pod works fine.

I currently have Regift working as a Git sub module

Chris

On 19 Sep 2015, at 4:57 PM, Matthew Palmer notifications@github.com wrote:

Ah sorry I meant that if you wanted obj c support in master, the best way to do that would be to submit a PR making Regift a public class, rather than adding the RegiftHelper class

— Reply to this email directly or view it on GitHub.