search

matthewprenger / CurseGradle

Gradle plugin to upload Minecraft mods to CurseForge
MIT License
1 stars 1 forks source link

No support for "non-minecraft" CurseForge sites #12

Open dries007 opened 6 years ago

dries007 commented 6 years ago

Hi, I'm using this plugin in a multi-version spanning Minecraft mod, that also has a Bukkit version.

The bukkit version doesn't upload correctly because the API's base URL is dev.bukkit.org instead of minecraft.curseforge.com. If this was made settable, it would allow not only bukkit plugins, but also all other sites, such as Terraria, KSP and others.

Please consider adding support, Thanks in advance, Dries

dshadowwolf commented 6 years ago

@matthewprenger hrm... currently the domain is hard-coded as a final - I've been looking at this and pondering how to fix this, would you prefer a DSL setting with it defaulting to the current or is there another method that you'd like to see implemented ?

matthewprenger commented 6 years ago

@dshadowwolf In my mind this would be a field in the project closure where the default is the Minecraft url. Something like:

project {
    apiUrl = 'https://dev.bukkit.org'
    id = '1234'
}

The CurseVersions class would also have to be refactored to handle multiple games.

dries007 commented 6 years ago

@matthewprenger This was what I was hoping for :+1:

dshadowwolf commented 6 years ago

@matthewprenger that is pretty close to what I was thinking of - though I'd had a thought of maybe having some predefined values somewhere for convenience.... I'll get on this in a few - Windows just had to update on me.

Cloudate9 commented 2 years ago

Over 3 years later, is the conclusion that this is not going to be added? Support for Bukkit or other games would be great, if possible...

dshadowwolf commented 2 years ago

I've been running on the edge of burnout for about 30 months now - usually falling just on the "burned out" side of things - so I've really not been able to find any motivation for any hobbies involving coding. Sorry, if anything is to come of this, it won't be a PR from me.

Cloudate9 commented 2 years ago

I've been running on the edge of burnout for about 30 months now - usually falling just on the "burned out" side of things - so I've really not been able to find any motivation for any hobbies involving coding. Sorry, if anything is to come of this, it won't be a PR from me.

Dw, take your rest. Maybe I'll create a pr if I ever find time.

jriwanek commented 2 years ago

See PR#36