search

matthewrudy / memoist

ActiveSupport::Memoizable with a few enhancements
MIT License
921 stars 99 forks source link

Stop raising when already memoized [Fixes #21], [Fixes #32] #33

Closed pboling closed 9 years ago

pboling commented 9 years ago

As discussed here

I recommend a minor version bump for this as it removes the old AlreadyMemoizedError class, and is a behavioral change.

matthewrudy commented 9 years ago

this looks fine, but I'm going to change the 3rd commit to warn and return

to avoid the big indentation change

matthewrudy commented 9 years ago

this was merged manually

pboling commented 9 years ago

@matthewrudy Awesome. I would've done the same but I wasn't sure if return was allowed in that context with all the fancy meta programming. I actually did the PR via the Github code editing tools. :)

matthewrudy commented 9 years ago

Ha, yeah I tried using the github tools for a while, when I had no computer. It kind of works on desktop, but it's almost impossible on mobile (mostly because of the way it catches input... text always gets lost)

http://prose.io works quite well, though. Although it doesn't capture the full git workflow.

Anyway, thanks for your help.